Avoid a useless redirect with site title and home link blocks #65672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Bug
Chouby
changed the title
|
@Chouby, do you mind rebasing your branch on top of the latest trunk? That should unblock GitHub CI checks. |
|
One test is still failing : It's not very surprising as 'http://' . WP_TESTS_DOMAIN doesn't account the fact that the home url can sometimes have a trailing slash and sometimes not.My first idea to work around this would be to replace it by home_url( '/' ) but I usually don't like to use the same function in the test and the tested code. What do you think?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65670
Why?
Avoid a redirect caused by the link in the site title block when WordPress is installed in a sufolder or on multisite with sites in folder.
How?
Use
home_url( '/' ) instead ofhome_url()`Testing Instructions
https://mysite.com/wordpress/instead ofhttps://mysite.com/wordpressin the current stable version.